Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default value for mdmc_average in Accuracy as per documentation #1036

Merged

Conversation

burglarhobbit
Copy link
Contributor

@burglarhobbit burglarhobbit commented May 18, 2022

What does this PR do?

This PR fixes the default value in argument for mdmc_average from "global" to None as per the documentation of Accuracy. This is also supported by the default value of mdmc_average in the documentation and code for F1Score, Precision and Recall.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1036 (e4a10f6) into master (4a28149) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1036   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         181     181           
  Lines        8004    8004           
======================================
- Hits         7582    7581    -1     
- Misses        422     423    +1     

@justusschock
Copy link
Member

@burglarhobbit thanks for this PR. It seems that you need to adjust some of these failing tests before we can merge this PR :)

@Borda Borda added the bug / fix Something isn't working label May 19, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 25, 2022
@mergify mergify bot added the ready label May 25, 2022
@Borda Borda enabled auto-merge (squash) May 25, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants