Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduction for full image in SSIM #1204

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 3, 2022

What does this PR do?

Fixes #1186
Removes the reduction that is done in ssim when return_full_image=True, as the argument name indicates in this case no reduction should be applied.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Sep 3, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Sep 3, 2022
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #1204 (ee59952) into master (bad3607) will decrease coverage by 52%.
The diff coverage is 67%.

@@           Coverage Diff            @@
##           master   #1204     +/-   ##
========================================
- Coverage      94%     42%    -52%     
========================================
  Files         185     185             
  Lines        8405    8407      +2     
========================================
- Hits         7893    3554   -4339     
- Misses        512    4853   +4341     

@Borda Borda enabled auto-merge (squash) September 5, 2022 19:25
@mergify mergify bot added the ready label Sep 5, 2022
@Borda Borda merged commit 19355a9 into master Sep 6, 2022
@Borda Borda deleted the bugfix/no_reduction_for_full_image branch September 6, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduction on full image not required?
3 participants