[MPS support] Make Jaccard Index working on MPS #1205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1196
_bincount
calculation forMPS
to run for loop fallbacktorch.where
implementation to applyabsent_score
instead of relying on item assignmentThere's still a warning on PyTorch side (using CPU fallback for some operations; see
UserWarning
below), however,no actions on our users' side are now required and the results are obtained smoothly. Calculation runs with warnings (but without errors!) both with
PYTORCH_ENABLE_MPS_FALLBACK=0
andPYTORCH_ENABLE_MPS_FALLBACK=1
.(tested on my M1 Mac)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃