Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalize argument to certain image metrics #1246

Merged
merged 9 commits into from
Nov 8, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 29, 2022

What does this PR do?

Fixes #1244
Adds normalize argument to inception, kid, fid metric to allow passing in float images

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Sep 29, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Sep 29, 2022
@SkafteNicki SkafteNicki marked this pull request as ready for review October 24, 2022 09:12
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1246 (0858d54) into master (00bb1ed) will decrease coverage by 49%.
The diff coverage is 75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1246     +/-   ##
========================================
- Coverage      87%     38%    -49%     
========================================
  Files         195     195             
  Lines       11348   11360     +12     
========================================
- Hits         9840    4282   -5558     
- Misses       1508    7078   +5570     

@mergify mergify bot added the ready label Oct 25, 2022
@Borda Borda mentioned this pull request Oct 25, 2022
4 tasks
@Borda Borda enabled auto-merge (squash) October 25, 2022 20:55
@Borda
Copy link
Member

Borda commented Nov 3, 2022

@justusschock ^^ pls 🐰

@mergify mergify bot added the has conflicts label Nov 3, 2022
@mergify mergify bot removed the has conflicts label Nov 5, 2022
@Borda Borda merged commit e0f6406 into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow FID to Use Float Images
3 participants