Fix broken clone method for classification metrics #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda,
tchaton and
ethanwharris
as code owners
SkafteNicki
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1250 +/- ##
======================================
Coverage 86% 86%
======================================
Files 193 195 +2
Lines 11404 11463 +59
======================================
+ Hits 9778 9836 +58
- Misses 1626 1627 +1 |
stancld
approved these changes
Oct 5, 2022
Borda
approved these changes
Oct 5, 2022
for more information, see https://pre-commit.ci
…htning/metrics into bugfix/broken_cloning
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
* fix clone method * chlog Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2856e0b)
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
* fix clone method * chlog Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2856e0b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1249
metric.clone()method is broken after the refactor. Try to fix it.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃