bugfix: Evaluate pred_lsum only if lsum in rouge_keys #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1257 Evaluate pred_lsum only if lsum in rouge_keys to avoid downloading "punkt" package from `nltk`, which raises an error when using e.g. DDP.
stancld
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
stancld
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
========================================
- Coverage 86% 44% -42%
========================================
Files 195 195
Lines 11462 11463 +1
========================================
- Hits 9835 5005 -4830
- Misses 1627 6458 +4831 |
SkafteNicki
approved these changes
Oct 8, 2022
Borda
approved these changes
Oct 10, 2022
Borda
reviewed
Oct 10, 2022
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
Evaluate pred_lsum only if lsum in rouge_keys to avoid downloading "punkt" package from `nltk`, which raises an error when using e.g. DDP. * chlog * lower Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit fbfe974)
Borda
pushed a commit
that referenced
this pull request
Oct 21, 2022
Evaluate pred_lsum only if lsum in rouge_keys to avoid downloading "punkt" package from `nltk`, which raises an error when using e.g. DDP. * chlog * lower Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit fbfe974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257
Evaluate pred_lsum only if lsum in rouge_keys to avoid downloading "punkt" package from
nltk, which raises an error when using e.g. DDP.What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃