Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add half precision testing [2/n] #135

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Add half precision testing [2/n] #135

merged 7 commits into from
Mar 29, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 26, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Add half testing for the remaining regression metrics.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 26, 2021
@SkafteNicki SkafteNicki added this to the 0.3 milestone Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #135 (9e21f63) into master (53d5701) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #135     +/-   ##
=========================================
  Coverage   96.76%   96.76%             
=========================================
  Files         156       78     -78     
  Lines        4816     2410   -2406     
=========================================
- Hits         4660     2332   -2328     
+ Misses        156       78     -78     
Flag Coverage Δ
Linux 79.29% <100.00%> (+0.01%) ⬆️
Windows 79.29% <100.00%> (+0.01%) ⬆️
cpu 96.76% <100.00%> (+<0.01%) ⬆️
gpu ?
macOS 96.76% <100.00%> (+<0.01%) ⬆️
pytest 96.76% <100.00%> (+<0.01%) ⬆️
python3.6 96.75% <100.00%> (+<0.01%) ⬆️
python3.8 96.76% <100.00%> (+<0.01%) ⬆️
python3.9 96.76% <100.00%> (+<0.01%) ⬆️
torch1.3.1 95.55% <100.00%> (+<0.01%) ⬆️
torch1.4.0 95.68% <100.00%> (+<0.01%) ⬆️
torch1.8.1 96.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etrics/functional/regression/explained_variance.py 100.00% <100.00%> (ø)
torchmetrics/functional/regression/r2score.py 95.12% <100.00%> (+0.12%) ⬆️
.../torchmetrics/regression/mean_squared_log_error.py
...rics/functional/classification/hamming_distance.py
__w/1/s/torchmetrics/wrappers/__init__.py
.../1/s/torchmetrics/retrieval/retrieval_precision.py
__w/1/s/torchmetrics/classification/iou.py
...ics/functional/classification/average_precision.py
...1/s/torchmetrics/functional/classification/dice.py
...torchmetrics/functional/classification/__init__.py
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d5701...9e21f63. Read the comment docs.

@SkafteNicki SkafteNicki added test / CI testing or CI and removed enhancement New feature or request labels Mar 26, 2021
@Borda Borda added the ready label Mar 28, 2021
@Borda Borda enabled auto-merge (squash) March 29, 2021 10:22
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit b7312a2 into master Mar 29, 2021
@Borda Borda deleted the half_testing2 branch March 29, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants