Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot() functionality to audio metrics #1434

Merged
merged 61 commits into from
Feb 17, 2023

Conversation

shhs29
Copy link
Contributor

@shhs29 shhs29 commented Jan 8, 2023

What does this PR do?

Fixes #1406

Currently, plot functionality is added for pesq metric. The test for plotting passes locally. However, the workflows on CI are failing.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@shhs29 shhs29 changed the title Add plot functionality to PerceptualEvaluationSpeechQuality Add plot functionality to audio metrics Jan 8, 2023
@shhs29 shhs29 changed the title Add plot functionality to audio metrics [wip] Add plot functionality to audio metrics Jan 8, 2023
@shhs29 shhs29 mentioned this pull request Jan 9, 2023
11 tasks
@Borda
Copy link
Member

Borda commented Feb 3, 2023

@SkafteNicki @justusschock mind have look 🦦

@SkafteNicki SkafteNicki marked this pull request as ready for review February 3, 2023 12:35
@shhs29
Copy link
Contributor Author

shhs29 commented Feb 6, 2023

Hi @shhs29, I looked through your PR and fixed the problems with the tests (a missing installation in the CI was the main problem). Can you add for the remaining audio metrics and then we can get this merged? :) Thanks for your work.

@SkafteNicki Thanks a lot for the help. I will add plot functionality for other audio metrics and make it available soon.

No problem. Just tag me when you are done with the rest and I can help cleanup and fix anything that may be missing/fails :]

@SkafteNicki I have added plot functionality for all the audio metrics. However, I am unsure about the lower and upper bounds of these metrics. Also, a couple of Github actions are failing, which I suspect is due to some incorrect/insufficient imports. I would appreciate your feedback on the same.

@SkafteNicki
Copy link
Member

@shhs29 thanks, I will take a look at it soon. We are experience problems with our CI at the moment, which should hopefully be solved soon also.

src/torchmetrics/audio/pesq.py Outdated Show resolved Hide resolved
@Borda Borda changed the title Add plot functionality to audio metrics Add plot() functionality to audio metrics Feb 13, 2023
@Borda Borda enabled auto-merge (squash) February 13, 2023 18:39
@Borda Borda disabled auto-merge February 17, 2023 03:47
@Borda Borda merged commit 50d137c into Lightning-AI:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .plot() to all modular metrics
3 participants