Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bincount on XLA #1471

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Fixed bincount on XLA #1471

merged 5 commits into from
Jan 31, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 31, 2023

What does this PR do?

Fixes #1466
bincount in torch is not implemented for XLA. We have a fallback solution already for MPS so this PR simply also make XLA computations fallback to that solution.

Not sure about testing, the user in the linked issue is reporting that it is working.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jan 31, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Jan 31, 2023
@Borda
Copy link
Member

Borda commented Jan 31, 2023

changelog? :)

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1471 (0d89765) into master (4f1b62b) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1471   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files         213     213           
  Lines       10920   10921    +1     
======================================
+ Hits         9792    9793    +1     
  Misses       1128    1128           

@Borda Borda enabled auto-merge (squash) January 31, 2023 13:45
@SkafteNicki SkafteNicki mentioned this pull request Jan 31, 2023
@mergify mergify bot added the ready label Jan 31, 2023
@Borda Borda merged commit 2ce0efb into master Jan 31, 2023
@Borda Borda deleted the xla_test branch January 31, 2023 18:48
Borda pushed a commit that referenced this pull request Feb 20, 2023
(cherry picked from commit 2ce0efb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XLA support
3 participants