Fix Metric.__iter__ by setting it to None
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValerianRey
requested review from
SkafteNicki,
justusschock,
Borda,
tchaton and
ethanwharris
as code owners
Borda
changed the title
Metric.__iter__ by setting it to None
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
======================================
- Coverage 89% 89% -0%
======================================
Files 216 216
Lines 11242 11241 -1
======================================
- Hits 9984 9983 -1
Misses 1258 1258 |
SkafteNicki
approved these changes
Feb 22, 2023
Borda
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1536
Before submitting
PR review
Did you have fun?
Yes!