Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information Retrieval (5/5) #160

Merged
merged 40 commits into from
Apr 6, 2021
Merged

Information Retrieval (5/5) #160

merged 40 commits into from
Apr 6, 2021

Conversation

lucadiliello
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Implements Normalized Discounted Cumulative Gain for IR. Original discussion here

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #160 (c1f32a9) into master (12eea74) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   96.83%   96.87%   +0.03%     
==========================================
  Files         164      168       +4     
  Lines        4996     5058      +62     
==========================================
+ Hits         4838     4900      +62     
  Misses        158      158              
Flag Coverage Δ
Linux 79.35% <91.17%> (+0.13%) ⬆️
Windows 79.35% <91.17%> (+0.13%) ⬆️
cpu 96.87% <100.00%> (+0.03%) ⬆️
gpu 96.87% <ø> (+0.03%) ⬆️
macOS 96.87% <100.00%> (+0.03%) ⬆️
pytest 96.87% <100.00%> (+0.03%) ⬆️
python3.6 96.87% <100.00%> (+0.03%) ⬆️
python3.8 96.87% <100.00%> (+0.03%) ⬆️
python3.9 96.87% <100.00%> (+0.03%) ⬆️
torch1.3.1 ?
torch1.4.0 ?
torch1.8.1 96.87% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/__init__.py 100.00% <ø> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/retrieval/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/retrieval/ndcg.py 100.00% <100.00%> (ø)
torchmetrics/retrieval/__init__.py 100.00% <100.00%> (ø)
torchmetrics/retrieval/retrieval_ndcg.py 100.00% <100.00%> (ø)
torchmetrics/utilities/checks.py 92.77% <100.00%> (ø)
__w/1/s/torchmetrics/__init__.py 100.00% <0.00%> (ø)
__w/1/s/torchmetrics/utilities/checks.py 92.77% <0.00%> (ø)
__w/1/s/torchmetrics/retrieval/__init__.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12eea74...c1f32a9. Read the comment docs.

@Borda Borda added the enhancement New feature or request label Apr 6, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda Borda enabled auto-merge (squash) April 6, 2021 14:27
@Borda Borda added this to the 0.3 milestone Apr 6, 2021
@Borda
Copy link
Member

Borda commented Apr 6, 2021

@lucadiliello mind adding an entry to changelog... 🐰

@Borda Borda added the ready label Apr 6, 2021
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
auto-merge was automatically disabled April 6, 2021 17:11

Head branch was pushed to by a user without write access

auto-merge was automatically disabled April 6, 2021 17:11

Head branch was pushed to by a user without write access

@pep8speaks
Copy link

pep8speaks commented Apr 6, 2021

Hello @lucadiliello! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-06 19:00:34 UTC

@SkafteNicki SkafteNicki enabled auto-merge (squash) April 6, 2021 17:21
@Borda
Copy link
Member

Borda commented Apr 6, 2021

@lucadiliello mind resolve conflicts and fix the GPU failer :]

auto-merge was automatically disabled April 6, 2021 18:33

Head branch was pushed to by a user without write access

@SkafteNicki SkafteNicki enabled auto-merge (squash) April 6, 2021 19:13
@SkafteNicki SkafteNicki merged commit 92ea4d7 into Lightning-AI:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants