-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename args: is_multiclass -> multiclass #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 96.87% 95.99% -0.89%
==========================================
Files 168 84 -84
Lines 5058 2571 -2487
==========================================
- Hits 4900 2468 -2432
+ Misses 158 103 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The or is fine, but why do we want to deal with that topic again? Thought we already settled this?
what do you mean? |
what about backwards compatibility? |
@SkafteNicki mind re-check :] |
Before submitting
What does this PR do?
fix unclear argument...
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃