Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename args: is_multiclass -> multiclass #162

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 6, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

fix unclear argument...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Apr 6, 2021
@Borda Borda added this to the 0.3 milestone Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #162 (c089503) into master (92ea4d7) will decrease coverage by 0.88%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   96.87%   95.99%   -0.89%     
==========================================
  Files         168       84      -84     
  Lines        5058     2571    -2487     
==========================================
- Hits         4900     2468    -2432     
+ Misses        158      103      -55     
Flag Coverage Δ
Linux 78.76% <54.16%> (-0.60%) ⬇️
Windows 78.76% <54.16%> (-0.60%) ⬇️
cpu 95.99% <66.66%> (-0.89%) ⬇️
gpu ?
macOS 95.99% <66.66%> (-0.89%) ⬇️
pytest 95.99% <66.66%> (-0.89%) ⬇️
python3.6 95.98% <66.66%> (-0.89%) ⬇️
python3.8 95.99% <66.66%> (-0.89%) ⬇️
python3.9 95.99% <66.66%> (-0.89%) ⬇️
torch1.3.1 94.85% <66.66%> (-0.87%) ⬇️
torch1.4.0 94.98% <66.66%> (-0.87%) ⬇️
torch1.8.1 95.99% <66.66%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rics/functional/classification/precision_recall.py 90.47% <40.00%> (-9.53%) ⬇️
torchmetrics/classification/f_beta.py 84.61% <42.85%> (-15.39%) ⬇️
torchmetrics/classification/precision_recall.py 87.50% <42.85%> (-12.50%) ⬇️
...chmetrics/functional/classification/stat_scores.py 93.84% <42.85%> (-6.16%) ⬇️
torchmetrics/functional/classification/f_beta.py 92.00% <50.00%> (-8.00%) ⬇️
torchmetrics/classification/stat_scores.py 97.59% <60.00%> (-2.41%) ⬇️
torchmetrics/utilities/checks.py 92.77% <100.00%> (ø)
__w/1/s/torchmetrics/info.py
__w/1/s/torchmetrics/collections.py
...etrics/functional/regression/explained_variance.py
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ea4d7...c089503. Read the comment docs.

@Borda Borda enabled auto-merge (squash) April 6, 2021 20:49
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or is fine, but why do we want to deal with that topic again? Thought we already settled this?

@Borda
Copy link
Member Author

Borda commented Apr 6, 2021

why do we want to deal with that topic again

what do you mean?

@SkafteNicki
Copy link
Member

what about backwards compatibility?

@Borda Borda changed the title rename args: is_multiclass -> multiclass rename args: is_multiclass -> multiclass [wip] Apr 7, 2021
@Borda Borda changed the title rename args: is_multiclass -> multiclass [wip] rename args: is_multiclass -> multiclass Apr 7, 2021
@Borda
Copy link
Member Author

Borda commented Apr 7, 2021

@SkafteNicki mind re-check :]

@Borda Borda merged commit 96ab7bd into master Apr 7, 2021
@Borda Borda deleted the refactor/is_multiclass branch April 7, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants