Warning on wrong call order #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
|
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-03 17:14:55 UTC |
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 79.67% 79.68%
=======================================
Files 90 90
Lines 2874 2879 +5
=======================================
+ Hits 2290 2294 +4
- Misses 584 585 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Apr 7, 2021
|
@SkafteNicki is this ready to go? |
|
@maximsch2 mind check comments/questions from @SkafteNicki? |
|
LGTM with the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Warn user if
computeis called beforeupdateas most metrics are meaningless or will produce errors if their states have not been updated. Will return 0.0 in this case.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃