Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restrictive input check in pearson corr coef #1649

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1647
One of the check of the input is a bit too restrictive, such that only input of the form [N,1] is allowed but not [N,]. Changes the check to allow both.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 24, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 24, 2023
@SkafteNicki SkafteNicki changed the title Fix restrictive input in pearson corr coef Fix restrictive input check in pearson corr coef Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1649 (6ab2aad) into master (685391d) will decrease coverage by 49%.
The diff coverage is 10%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1649     +/-   ##
========================================
- Coverage      89%     39%    -49%     
========================================
  Files         228     228             
  Lines       12363   12450     +87     
========================================
- Hits        10945    4892   -6053     
- Misses       1418    7558   +6140     

@mergify mergify bot removed the has conflicts label Mar 28, 2023
@mergify mergify bot requested a review from a team March 28, 2023 12:50
@mergify mergify bot added the ready label Mar 28, 2023
@Borda Borda merged commit be0a9e6 into master Mar 28, 2023
@Borda Borda deleted the bugfix/pearson_1d_input branch March 28, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pearson Correlation Coefficient raises error when 2D tensor but single task
3 participants