Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting 18/n #1660

Merged
merged 11 commits into from
Mar 31, 2023
Merged

Add plotting 18/n #1660

merged 11 commits into from
Mar 31, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1406
Adds remaining classification metrics.
This should be the remaining metrics, only need to take care of MetricCollection now and some documentation.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 28, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 28, 2023
@mergify mergify bot requested a review from a team March 28, 2023 08:32
@Borda Borda enabled auto-merge (squash) March 28, 2023 15:05
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1660 (4533c3d) into master (d029525) will increase coverage by 0%.
The diff coverage is 91%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1660   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         228     228           
  Lines       12450   12502   +52     
======================================
+ Hits        11030   11080   +50     
- Misses       1420    1422    +2     

@mergify mergify bot added the ready label Mar 28, 2023
@Borda Borda disabled auto-merge March 31, 2023 06:08
@mergify mergify bot removed the has conflicts label Mar 31, 2023
@Borda Borda merged commit 2c90745 into master Mar 31, 2023
@Borda Borda deleted the plot/18 branch March 31, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants