Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports: deprecate from pkg root [2/n] Detection #1694

Merged
merged 8 commits into from
Apr 11, 2023
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 6, 2023

What does this PR do?

Part of #1681 (comment)

  • class version
  • functional
  • tests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Apr 6, 2023
@Borda Borda added this to the v1.0.0 milestone Apr 6, 2023
@Borda Borda enabled auto-merge (squash) April 6, 2023 11:08
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1694 (a0705d6) into master (a8bafa2) will decrease coverage by 49%.
The diff coverage is 87%.

❗ Current head a0705d6 differs from pull request most recent head ceda635. Consider uploading reports for the commit ceda635 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1694     +/-   ##
========================================
- Coverage      89%     40%    -49%     
========================================
  Files         230     230             
  Lines       12860   12872     +12     
========================================
- Hits        11410    5117   -6293     
- Misses       1450    7755   +6305     

@Borda Borda requested a review from a team April 6, 2023 12:51
@mergify mergify bot added the ready label Apr 8, 2023
@Borda Borda disabled auto-merge April 11, 2023 12:56
@Borda Borda merged commit 60e4177 into master Apr 11, 2023
@Borda Borda deleted the imports/detect branch April 11, 2023 12:57
@mergify mergify bot removed the ready label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants