Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports: deprecate from pkg root [5/n] Text #1703

Merged
merged 9 commits into from
Apr 12, 2023
Merged

imports: deprecate from pkg root [5/n] Text #1703

merged 9 commits into from
Apr 12, 2023

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Apr 11, 2023

What does this PR do?

Part of #1681 (comment)

  • class version
  • functional
  • tests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@stancld stancld marked this pull request as ready for review April 11, 2023 20:33
@mergify mergify bot removed the has conflicts label Apr 11, 2023
@Borda Borda added the refactoring refactoring and code health label Apr 11, 2023
@Borda Borda added this to the v1.0.0 milestone Apr 11, 2023
@Borda Borda enabled auto-merge (squash) April 12, 2023 15:37
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1703 (0279bf2) into master (f6dc545) will decrease coverage by 42%.
The diff coverage is 72%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1703     +/-   ##
========================================
- Coverage      88%     47%    -42%     
========================================
  Files         234     236      +2     
  Lines       13082   13230    +148     
========================================
- Hits        11549    6152   -5397     
- Misses       1533    7078   +5545     

@mergify mergify bot added the ready label Apr 12, 2023
@Borda Borda merged commit f75757b into master Apr 12, 2023
@Borda Borda deleted the imports/text branch April 12, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants