Fix backward compatability for older versions of lightning

[SkafteNicki]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?

What does this PR do?

Fixes #152

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #182 (bb78a9d) into master (bc5f9a9) will decrease coverage by 8.30%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   96.01%   87.70%   -8.31%     
==========================================
  Files         180      180              
  Lines        5744     5750       +6     
==========================================
- Hits         5515     5043     -472     
- Misses        229      707     +478     

Flag	Coverage Δ
Linux	79.33% <78.57%> (+0.05%)	⬆️
Windows	79.33% <78.57%> (+0.05%)	⬆️
cpu	79.33% <78.57%> (-16.66%)	⬇️
gpu	96.04% <ø> (+0.01%)	⬆️
macOS	79.33% <78.57%> (-16.66%)	⬇️
pytest	87.70% <78.57%> (-8.31%)	⬇️
python3.6	?
python3.8	?
python3.9	?
torch1.3.1	?
torch1.8.1	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
torchmetrics/classification/accuracy.py	72.54% <0.00%> (-23.61%)	⬇️
torchmetrics/functional/classification/accuracy.py	57.57% <ø> (-36.37%)	⬇️
torchmetrics/utilities/imports.py	85.29% <80.00%> (+3.15%)	⬆️
torchmetrics/metric.py	55.84% <100.00%> (-39.31%)	⬇️
torchmetrics/utilities/distributed.py	22.85% <0.00%> (-74.29%)	⬇️
torchmetrics/classification/auc.py	47.61% <0.00%> (-52.39%)	⬇️
torchmetrics/functional/classification/auroc.py	46.15% <0.00%> (-40.01%)	⬇️
torchmetrics/functional/regression/psnr.py	60.60% <0.00%> (-36.37%)	⬇️
... and 50 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5f9a9...bb78a9d. Read the comment docs.

[Borda]

can we also add an integration test for this as we have tested with PL 1.2 and they were all passing...

[Borda]

The problem seems to be cyclic import as the available func tries to import the package but in PL case it has TM as a dependency...

[Borda]

@SkafteNicki seems that the integration fails... mind check it?

[pep8speaks]

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-20 09:08:09 UTC

[ananthsub]

isn't this backwards? shouldn't lightning be accounting for the torchmetrics version, not the other way around?

[SkafteNicki]

since we cannot change earlier versions of lightning, we need to do the change in torchmetrics