Fix concatenation of zero dim states #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
SkafteNicki
commented
May 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 184 184
Lines 6004 6010 +6
=======================================
+ Hits 5812 5818 +6
Misses 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Borda
approved these changes
May 5, 2021
Borda
pushed a commit
that referenced
this pull request
May 10, 2021
* fix * changelog Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit 33864db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #227
Makes sure that metrics that use list as state can take in 0 dim input and the concatenation still works.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃