Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing for attributes #314

Merged
merged 11 commits into from
Jul 5, 2021
Merged

add typing for attributes #314

merged 11 commits into from
Jul 5, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 24, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request refactoring refactoring and code health labels Jun 24, 2021
@Borda Borda marked this pull request as ready for review June 24, 2021 16:52
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #314 (ac68eff) into master (17130f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   96.38%   96.39%           
=======================================
  Files         112      112           
  Lines        3600     3657   +57     
=======================================
+ Hits         3470     3525   +55     
- Misses        130      132    +2     
Flag Coverage Δ
Linux 76.34% <100.00%> (+0.37%) ⬆️
Windows 76.34% <100.00%> (+0.37%) ⬆️
cpu 96.39% <100.00%> (+0.05%) ⬆️
gpu ?
macOS 96.39% <100.00%> (+0.05%) ⬆️
pytest 96.39% <100.00%> (+<0.01%) ⬆️
python3.6 95.54% <100.00%> (?)
python3.8 96.39% <100.00%> (+0.05%) ⬆️
python3.9 96.28% <100.00%> (+0.05%) ⬆️
torch1.3.1 95.54% <100.00%> (?)
torch1.4.0 95.62% <100.00%> (+0.06%) ⬆️
torch1.9.0 96.28% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/stat_scores.py 98.36% <ø> (ø)
...metrics/functional/classification/kl_divergence.py 89.28% <ø> (ø)
torchmetrics/audio/si_sdr.py 100.00% <100.00%> (ø)
torchmetrics/audio/si_snr.py 100.00% <100.00%> (ø)
torchmetrics/audio/snr.py 100.00% <100.00%> (ø)
torchmetrics/average.py 96.15% <100.00%> (+0.32%) ⬆️
torchmetrics/classification/__init__.py 100.00% <100.00%> (ø)
torchmetrics/classification/accuracy.py 93.22% <100.00%> (+0.23%) ⬆️
torchmetrics/classification/auc.py 100.00% <100.00%> (ø)
torchmetrics/classification/auroc.py 91.30% <100.00%> (+0.39%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17130f1...ac68eff. Read the comment docs.

@Borda Borda marked this pull request as draft June 24, 2021 16:56
@Borda Borda added the help wanted Extra attention is needed label Jun 28, 2021
@Borda Borda changed the title add typing for compute & update add typing for attributes Jul 5, 2021
@Borda Borda marked this pull request as ready for review July 5, 2021 09:22
@Borda Borda merged commit 5e29a60 into master Jul 5, 2021
@Borda Borda deleted the typing/metrics-compute-update branch July 5, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant