Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune deprecated #319

Merged
merged 4 commits into from
Jun 25, 2021
Merged

prune deprecated #319

merged 4 commits into from
Jun 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 25, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

prune deprecated args

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 25, 2021
@Borda Borda added this to the v0.4 milestone Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #319 (551729f) into master (75793e4) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   75.84%   75.71%   -0.13%     
==========================================
  Files         106      105       -1     
  Lines        3444     3406      -38     
==========================================
- Hits         2612     2579      -33     
+ Misses        832      827       -5     
Flag Coverage Δ
Linux 75.71% <ø> (-0.13%) ⬇️
Windows 75.71% <ø> (-0.13%) ⬇️
cpu 75.71% <ø> (-0.13%) ⬇️
macOS 75.71% <ø> (-0.13%) ⬇️
pytest 75.71% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/f_beta.py 91.30% <ø> (-1.01%) ⬇️
torchmetrics/classification/precision_recall.py 87.09% <ø> (-1.80%) ⬇️
torchmetrics/classification/stat_scores.py 75.00% <ø> (-0.81%) ⬇️
torchmetrics/functional/classification/f_beta.py 66.66% <ø> (-1.97%) ⬇️
...rics/functional/classification/precision_recall.py 72.30% <ø> (-2.70%) ⬇️
...chmetrics/functional/classification/stat_scores.py 70.00% <ø> (-0.74%) ⬇️
...trics/functional/regression/mean_relative_error.py 100.00% <ø> (ø)
torchmetrics/utilities/__init__.py 100.00% <ø> (+31.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75793e4...551729f. Read the comment docs.

@Borda Borda added the ready label Jun 25, 2021
@Borda Borda enabled auto-merge (squash) June 25, 2021 14:31
@Borda Borda merged commit 5d16231 into master Jun 25, 2021
@Borda Borda deleted the prune/deprecate branch June 25, 2021 15:00
@Borda Borda self-assigned this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants