Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of more audio metrics #353

Closed
SkafteNicki opened this issue Jul 7, 2021 · 9 comments · Fixed by #535 or #536
Closed

Addition of more audio metrics #353

SkafteNicki opened this issue Jul 7, 2021 · 9 comments · Fixed by #535 or #536
Labels

Comments

@SkafteNicki
Copy link
Member

SkafteNicki commented Jul 7, 2021

🚀 Feature

Motivation

Feedback based on the newly release audio package (https://twitter.com/ai_rishikesh/status/1412707569710166019), here are a couple of other audio metrics it would be great if we added:

cc: @quancs

Pitch

Alternatives

Additional context

@SkafteNicki SkafteNicki added enhancement New feature or request help wanted Extra attention is needed labels Jul 7, 2021
@quancs
Copy link
Member

quancs commented Jul 7, 2021

@quancs
Copy link
Member

quancs commented Jul 7, 2021

Is it good to use pytorch to wrap the c++ implementation of PESQ, like other PESQ implementations?
@SkafteNicki

@SkafteNicki
Copy link
Member Author

@Borda can you help with answering what to do here? They use MIT license but they are against replications

@Borda
Copy link
Member

Borda commented Jul 7, 2021

according to their statement, we cannot use even modified their code... :/
I guess the only way would be to integrate it as dependency or ask @vBaiCai @SKb10 if they are willing to contribute to TM

@quancs
Copy link
Member

quancs commented Jul 7, 2021

I checked the speechmetric implementation...
It uses the two implementation as dependency......

@quancs
Copy link
Member

quancs commented Jul 7, 2021

according to their statement, we cannot use even modified their code... :/
I guess the only way would be to integrate it as dependency or ask @vBaiCai @SKb10 if they are willing to contribute to TM

This might be the only way...

@quancs quancs mentioned this issue Jul 18, 2021
4 tasks
@quancs
Copy link
Member

quancs commented Jul 19, 2021

Sorry, I forgot our disscussion here... @Borda
I closed my pull request of pesq... and I have invited ludlows to do this job.

@quancs
Copy link
Member

quancs commented Jul 19, 2021

Can you give an invitation to mpariente for stoi? His stoi is widely used in audio community. @Borda @SkafteNicki

@quancs
Copy link
Member

quancs commented Jul 19, 2021

As for MCD, I am not familiar with it. You can invite the owner of MCD package (https://github.com/MattShannon/mcd).

@quancs quancs mentioned this issue Sep 18, 2021
4 tasks
@Borda Borda removed the help wanted Extra attention is needed label Sep 20, 2021
@quancs quancs mentioned this issue Oct 13, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants