Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move image gradient #381

Merged
merged 8 commits into from
Jul 16, 2021
Merged

Move image gradient #381

merged 8 commits into from
Jul 16, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Moves the image_gradient metric to a image folder (now that we have a image package).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ready enhancement New feature or request labels Jul 16, 2021
@Borda
Copy link
Member

Borda commented Jul 16, 2021

seems some type error appeared...

@mergify mergify bot removed the has conflicts label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #381 (23e3ab3) into master (d6cb082) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   96.44%   96.36%   -0.09%     
==========================================
  Files         113      113              
  Lines        3690     3691       +1     
==========================================
- Hits         3559     3557       -2     
- Misses        131      134       +3     
Flag Coverage Δ
Linux 76.53% <100.00%> (+<0.01%) ⬆️
Windows 76.53% <100.00%> (+<0.01%) ⬆️
cpu 76.53% <100.00%> (-19.86%) ⬇️
gpu 96.36% <100.00%> (+<0.01%) ⬆️
macOS 76.53% <100.00%> (-19.86%) ⬇️
pytest 96.36% <100.00%> (-0.09%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/image/gradients.py 100.00% <ø> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/image/__init__.py 100.00% <100.00%> (ø)
torchmetrics/average.py 84.61% <0.00%> (-11.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cb082...23e3ab3. Read the comment docs.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove the original image_gradients.py because it collided with the same-named function imported in __init__.py

UNEXPECTED EXCEPTION: TypeError("'module' object is not callable")
Traceback (most recent call last):
  File "/usr/lib/python3.8/doctest.py", line 1336, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest torchmetrics.functional.image.gradients.image_gradients[3]>", line 1, in <module>
TypeError: 'module' object is not callable

@Borda Borda merged commit 393a391 into master Jul 16, 2021
@Borda Borda deleted the image_grad_move branch July 16, 2021 21:10
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants