Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move functional psnr & ssim to image #382

Merged
merged 9 commits into from
Jul 16, 2021
Merged

move functional psnr & ssim to image #382

merged 9 commits into from
Jul 16, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda
Copy link
Member Author

Borda commented Jul 16, 2021

@SkafteNicki just see that PSNR is used also in info retrieval, so shall it really live in image?

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #382 (7cf94e1) into master (a5af6d8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   96.46%   96.44%   -0.02%     
==========================================
  Files         114      113       -1     
  Lines        3705     3690      -15     
==========================================
- Hits         3574     3559      -15     
  Misses        131      131              
Flag Coverage Δ
Linux 76.53% <100.00%> (-0.10%) ⬇️
Windows 76.53% <100.00%> (-0.10%) ⬇️
cpu 96.39% <100.00%> (-0.02%) ⬇️
gpu 96.36% <100.00%> (-0.02%) ⬇️
macOS 96.39% <100.00%> (-0.02%) ⬇️
pytest 96.44% <100.00%> (-0.02%) ⬇️
python3.6 95.55% <100.00%> (-0.02%) ⬇️
python3.8 96.39% <100.00%> (-0.02%) ⬇️
python3.9 96.28% <100.00%> (-0.02%) ⬇️
torch1.3.1 95.55% <100.00%> (-0.02%) ⬇️
torch1.4.0 95.63% <100.00%> (-0.02%) ⬇️
torch1.9.0 96.28% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/image/psnr.py 96.96% <ø> (ø)
torchmetrics/functional/image/ssim.py 100.00% <ø> (ø)
torchmetrics/regression/__init__.py 100.00% <ø> (ø)
torchmetrics/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/image/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/regression/__init__.py 100.00% <100.00%> (ø)
torchmetrics/image/psnr.py 100.00% <100.00%> (ø)
torchmetrics/image/ssim.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5af6d8...7cf94e1. Read the comment docs.

@mergify mergify bot removed the has conflicts label Jul 16, 2021
@Borda Borda added the ready label Jul 16, 2021
@Borda Borda merged commit d6cb082 into master Jul 16, 2021
@Borda Borda deleted the refactor/images branch July 16, 2021 19:30
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants