Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WER metric #383

Merged
merged 63 commits into from
Jul 24, 2021
Merged

Adding WER metric #383

merged 63 commits into from
Jul 24, 2021

Conversation

gagan3012
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #52 (issue).

This PR adds the WER metric to torchmetrics

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 16, 2021

Hello @gagan3012! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-24 20:29:44 UTC

@Borda Borda added enhancement New feature or request New metric labels Jul 16, 2021
tests/functional/text_wer.py Outdated Show resolved Hide resolved
tests/text/test_wer.py Show resolved Hide resolved
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
Sean Naren and others added 2 commits July 23, 2021 13:11
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments :]

torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/text/wer.py Show resolved Hide resolved
@SkafteNicki
Copy link
Member

Also, please remember to add changelog :]

@SkafteNicki SkafteNicki mentioned this pull request Jul 23, 2021
4 tasks
gagan3012 and others added 5 commits July 23, 2021 09:49
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
@SkafteNicki SkafteNicki enabled auto-merge (squash) July 24, 2021 11:38
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]
Great job @gagan3012

docs/source/references/functional.rst Outdated Show resolved Hide resolved
tests/text/test_wer.py Outdated Show resolved Hide resolved
tests/text/test_wer.py Outdated Show resolved Hide resolved
tests/text/test_wer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki merged commit 397a089 into Lightning-AI:master Jul 24, 2021
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] WER
5 participants