Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float target support to class & functional NDCG #437

Merged

Conversation

alex-senov
Copy link
Contributor

@alex-senov alex-senov commented Aug 9, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #436

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Aug 9, 2021

Hello @obus! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-11 07:06:41 UTC

@alex-senov alex-senov force-pushed the bugfix/436_support-float-ndcg-target branch from e90abd5 to b3a5c58 Compare August 9, 2021 18:15
@alex-senov alex-senov force-pushed the bugfix/436_support-float-ndcg-target branch from 8997992 to 128f6a6 Compare August 9, 2021 18:17
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #437 (a91e08f) into master (484477a) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   95.98%   95.95%   -0.03%     
==========================================
  Files         129      129              
  Lines        4180     4178       -2     
==========================================
- Hits         4012     4009       -3     
- Misses        168      169       +1     
Flag Coverage Δ
Linux 74.79% <87.50%> (+0.05%) ⬆️
Windows 74.79% <87.50%> (+0.05%) ⬆️
cpu 95.95% <87.50%> (-0.03%) ⬇️
macOS 95.95% <87.50%> (-0.03%) ⬇️
pytest 95.95% <87.50%> (-0.03%) ⬇️
python3.6 95.21% <87.50%> (-0.03%) ⬇️
python3.8 95.95% <87.50%> (-0.03%) ⬇️
python3.9 95.88% <87.50%> (-0.03%) ⬇️
torch1.3.1 95.21% <87.50%> (-0.03%) ⬇️
torch1.4.0 95.28% <87.50%> (-0.03%) ⬇️
torch1.9.0 95.88% <87.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/retrieval/retrieval_ndcg.py 100.00% <ø> (ø)
torchmetrics/utilities/checks.py 91.32% <87.50%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484477a...a91e08f. Read the comment docs.

@SkafteNicki SkafteNicki added the enhancement New feature or request label Aug 10, 2021
@SkafteNicki SkafteNicki added this to the v0.6 milestone Aug 10, 2021
@Borda Borda force-pushed the master branch 2 times, most recently from 58f1e14 to caf7b0b Compare August 10, 2021 08:54
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments else looks good :]
Remember to add note in the changelog

torchmetrics/utilities/checks.py Show resolved Hide resolved
torchmetrics/retrieval/retrieval_ndcg.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki marked this pull request as ready for review August 16, 2021 11:11
@mergify mergify bot removed the ready label Aug 16, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) August 16, 2021 12:04
@mergify mergify bot added the ready label Aug 16, 2021
@Borda Borda disabled auto-merge August 17, 2021 07:39
@Borda Borda merged commit 1171a1f into Lightning-AI:master Aug 17, 2021
@Borda Borda modified the milestones: v0.6, v0.5 Aug 18, 2021
@alex-senov alex-senov deleted the bugfix/436_support-float-ndcg-target branch August 19, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nDCG can not be called with float targets
5 participants