-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add float target support to class & functional NDCG #437
Add float target support to class & functional NDCG #437
Conversation
Hello @obus! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-11 07:06:41 UTC |
e90abd5
to
b3a5c58
Compare
8997992
to
128f6a6
Compare
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 95.98% 95.95% -0.03%
==========================================
Files 129 129
Lines 4180 4178 -2
==========================================
- Hits 4012 4009 -3
- Misses 168 169 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
58f1e14
to
caf7b0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments else looks good :]
Remember to add note in the changelog
….com/Obus/metrics into bugfix/436_support-float-ndcg-target
Before submitting
What does this PR do?
Fixes #436
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃