fixes metric hashing #478
Merged
fixes metric hashing #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
added
bug / fix
justusschock
requested review from
ananyahjha93,
ethanwharris and
SeanNaren
as code owners
for more information, see https://pre-commit.ci
Co-authored-by: thomas chaton <thomas@grid.ai>
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=====================================
Coverage 96% 96%
=====================================
Files 130 130
Lines 4301 4301
=====================================
Hits 4126 4126
Misses 175 175 |
SkafteNicki
reviewed
Aug 24, 2021
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
SkafteNicki
approved these changes
Aug 24, 2021
Borda
approved these changes
Aug 24, 2021
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
pushed a commit
that referenced
this pull request
Aug 27, 2021
* fixes metric hashing * Update torchmetrics/metric.py * Apply suggestions from code review * chlog * fix test * fix decorator * fix decorator Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 3257c60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
We need the hashing to be unique. PyTorch relies on that for children discoverability.
before
hash(AUROC()) == hash(AUROC())evaluated to true when metrics had an empty non-tensor state (like an empty list) causing some attributes to be not appearing in the children.Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃