Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f1 score for macro and ignore index #495

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Fix f1 score for macro and ignore index #495

merged 5 commits into from
Sep 3, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 2, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #486

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #495 (f3255b4) into master (fd58980) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #495   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         130    130           
  Lines        4586   4586           
=====================================
+ Hits         4363   4373   +10     
+ Misses        223    213   -10     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a test for this seems it can be broken anytime in future the same way...

@mergify mergify bot added the ready label Sep 2, 2021
@SkafteNicki
Copy link
Member Author

@Borda have added test now. But we did not have test because its a corner case.

@Borda Borda merged commit e38cb70 into master Sep 3, 2021
@Borda Borda deleted the f1_fix branch September 3, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchmetrics.F1 bug with ignore_index and macro averaging
2 participants