Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MER - Match Error Rate #619

Merged
merged 20 commits into from
Nov 15, 2021
Merged

MER - Match Error Rate #619

merged 20 commits into from
Nov 15, 2021

Conversation

mahinlma
Copy link
Contributor

@mahinlma mahinlma commented Nov 13, 2021

Match Error Rate - This metric value indicates the percentage of words that were incorrectly predicted and inserted.

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Match Error Rate logic
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #619 (6e224ec) into master (b3f4727) will increase coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff          @@
##           master   #619   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         150    152    +2     
  Lines        5308   5362   +54     
=====================================
+ Hits         5050   5102   +52     
- Misses        258    260    +2     

torchmetrics/functional/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/mer.py Outdated Show resolved Hide resolved
mahinlma and others added 4 commits November 14, 2021 08:06
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@mahinlma mahinlma requested a review from Borda November 14, 2021 03:17
@mahinlma mahinlma changed the title Match Error Rate [MER] Match Error Rate Nov 14, 2021
@mahinlma mahinlma changed the title [MER] Match Error Rate MER - Match Error Rate Nov 14, 2021
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
mahinlma and others added 5 commits November 14, 2021 14:48
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@mahinlma mahinlma requested a review from Borda November 14, 2021 13:46
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller comments, else LGTM :]

torchmetrics/text/mer.py Outdated Show resolved Hide resolved
torchmetrics/text/mer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Nov 15, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) November 15, 2021 08:38
@SkafteNicki SkafteNicki merged commit b31599b into Lightning-AI:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants