Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer configuration #621

Merged
merged 35 commits into from
Nov 30, 2021
Merged

Devcontainer configuration #621

merged 35 commits into from
Nov 30, 2021

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Nov 14, 2021

What does this PR do?

Fixes #620

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #621 (757410e) into master (e0588f2) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #621   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         161    161           
  Lines        5781   5781           
=====================================
+ Hits         5499   5501    +2     
+ Misses        282    280    -2     

@Borda Borda added the enhancement New feature or request label Nov 15, 2021
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Nov 15, 2021

lets include some docs section how to use it... #620 (comment)

@twsl
Copy link
Contributor Author

twsl commented Nov 21, 2021

@Borda is there anything else missing?

.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) November 24, 2021 17:12
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @justusschock comment are adressed.

auto-merge was automatically disabled November 26, 2021 13:31

Head branch was pushed to by a user without write access

@Borda Borda enabled auto-merge (squash) November 26, 2021 14:37
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ((((nit: maybe we should replace tabs with spaces))))

auto-merge was automatically disabled November 27, 2021 20:02

Head branch was pushed to by a user without write access

@akihironitta akihironitta enabled auto-merge (squash) November 28, 2021 03:25
@justusschock justusschock enabled auto-merge (squash) November 30, 2021 10:46
@justusschock justusschock merged commit af461cc into Lightning-AI:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devcontainer Support
6 participants