Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Information Lost and Preserved - ASR metrics #630

Merged
merged 29 commits into from
Nov 24, 2021

Conversation

mahinlma
Copy link
Contributor

Word Information Lost and Preserved - metrics for ASR

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Word Information Lost and Preserved - metrics for ASR
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #630 (ebd2f8a) into master (ce2d1c7) will increase coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff          @@
##           master   #630   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         155    160    +5     
  Lines        5513   5597   +84     
=====================================
+ Hits         5246   5326   +80     
- Misses        267    271    +4     

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to comment here, PR looks very good.
Please refactor the _edit_distance into its own file to reduce duplicates.

torchmetrics/functional/text/wil.py Outdated Show resolved Hide resolved
torchmetrics/text/wil.py Outdated Show resolved Hide resolved
torchmetrics/text/wip.py Outdated Show resolved Hide resolved
@mahinlma mahinlma requested a review from Borda November 24, 2021 07:09
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

torchmetrics/text/wip.py Outdated Show resolved Hide resolved
torchmetrics/text/wil.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Nov 24, 2021
@SkafteNicki
Copy link
Member

@stancld could you take a look?

tests/text/test_wil.py Outdated Show resolved Hide resolved
docs/source/references/functional.rst Outdated Show resolved Hide resolved
tests/text/test_wip.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/helper.py Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) November 24, 2021 09:23
@mergify mergify bot removed the has conflicts label Nov 24, 2021
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for two minor comments regarding the inappropriate docstrings, LGTM! :]

torchmetrics/functional/text/wip.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/wip.py Outdated Show resolved Hide resolved
mergify bot and others added 2 commits November 24, 2021 11:55
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@mergify mergify bot removed the ready label Nov 24, 2021
auto-merge was automatically disabled November 24, 2021 16:05

Head branch was pushed to by a user without write access

@mergify mergify bot added the ready label Nov 24, 2021
@Borda Borda merged commit 6361a41 into Lightning-AI:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants