Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Extended Edit Distance (EED) metric #668

Merged
merged 85 commits into from
Jan 10, 2022

Conversation

mathemusician
Copy link
Contributor

Hello all, the only thing I've not done yet is update Changelog.md. I'm assuming it should be updated after review.

What does this PR do?

Fixes #635

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mathemusician, thanks for your contribution! :] I left some comments but we're on the way. You can also update CHANGELOG.md :]

torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/eed.py Outdated Show resolved Hide resolved
torchmetrics/text/eed.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #668 (be3814e) into master (3bd4fb0) will decrease coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff           @@
##           master   #668    +/-   ##
======================================
- Coverage      95%    95%    -0%     
======================================
  Files         167    169     +2     
  Lines        6596   6718   +122     
======================================
+ Hits         6272   6384   +112     
- Misses        324    334    +10     

@mathemusician
Copy link
Contributor Author

Thanks for taking a look at my code @stancld! Will implement changes soon.

@Borda Borda added this to the v0.7 milestone Dec 8, 2021
@mergify mergify bot removed the has conflicts label Jan 10, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jan 10, 2022
@Borda Borda merged commit 8ef281c into Lightning-AI:master Jan 10, 2022
@mathemusician
Copy link
Contributor Author

Thanks to everyone who reviewed my code and made this as good as it is now! :)

@Borda
Copy link
Member

Borda commented Jan 10, 2022

Thanks to everyone who reviewed my code and made this as good as it is now! :)

Thank you for your patience with us and for making this package even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EED
6 participants