Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly checks if ground truths are empty #684

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

OlofHarrysson
Copy link
Contributor

@OlofHarrysson OlofHarrysson commented Dec 13, 2021

What does this PR do?

Fixes #683

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #684 (c8a2c8b) into master (e95f148) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #684   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         166    166           
  Lines        6370   6370           
=====================================
  Hits         6063   6063           
  Misses        307    307           

@Borda Borda added the bug / fix Something isn't working label Dec 13, 2021
@Borda Borda added this to the v0.6 milestone Dec 13, 2021
@Borda Borda enabled auto-merge (squash) December 13, 2021 11:58
@mergify mergify bot added the ready label Dec 13, 2021
@Borda Borda merged commit d071eb2 into Lightning-AI:master Dec 13, 2021
Borda pushed a commit that referenced this pull request Dec 13, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d071eb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mAP metric crashes when there are no ground truth boxes
4 participants