-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix arg to metric collection #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 97.11% 97.07% -0.04%
==========================================
Files 59 59
Lines 1938 1949 +11
==========================================
+ Hits 1882 1892 +10
- Misses 56 57 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you also add return type annotations?
95f8535
to
a5cb115
Compare
Before submitting
What does this PR do?
Fixes #64
Adds a
prefix
argument to the metric collection for easy initialization of the same metric collection multiple times with adjusted keysPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃