Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collection kwargs filtering #707

Merged
merged 6 commits into from
Jan 4, 2022
Merged

Conversation

justusschock
Copy link
Member

What does this PR do?

Fixes #693

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #707 (bec6b79) into master (2e58596) will decrease coverage by 0%.
The diff coverage is 75%.

@@          Coverage Diff          @@
##           master   #707   +/-   ##
=====================================
- Coverage      73%    73%   -0%     
=====================================
  Files         166    166           
  Lines        6421   6424    +3     
=====================================
+ Hits         4690   4691    +1     
- Misses       1731   1733    +2     

@justusschock justusschock self-assigned this Jan 4, 2022
@justusschock justusschock added the bug / fix Something isn't working label Jan 4, 2022
@mergify mergify bot added the ready label Jan 4, 2022
@Borda Borda merged commit 8dd7d91 into master Jan 4, 2022
@Borda Borda deleted the fix/collection_kwargs_filter branch January 4, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword Argument Filtering for Metric Compositions/Collections does not behave as expected
3 participants