Smart update of metric collection #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren and
tchaton
as code owners
Borda
force-pushed
the
master
branch
3 times, most recently
from
3a0f7dc
to
317182c
Compare
4 tasks
for more information, see https://pre-commit.ci
SkafteNicki
commented
Jan 24, 2022
justusschock
approved these changes
Feb 8, 2022
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
for more information, see https://pre-commit.ci
Borda
reviewed
Feb 8, 2022
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
…g/metrics into smart_collection
|
Seems sphinx doesn't know |
|
@justusschock I changed the text to not include a hyperlink but instead just reference the class docs that are just below the sentence |
Borda
approved these changes
Feb 8, 2022
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
|
@SkafteNicki Beautiful addition ! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #143
Update
MetricCollectionsuch that metrics that have similar metric states (PrecisionandRecallfor example) we only calculate the metric state for one of them and then broadcast it to all other metrics with similar metric states.After the first call to update we checks if the metric states matches between any metrics. If they do we merge them into a compute group of metrics where we will only update the first and broadcast the state to the remaining metrics in the group
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃