-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix check for available modules #772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 171 171
Lines 6913 6926 +13
=====================================
+ Hits 6556 6563 +7
- Misses 357 363 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this PR fixes Lightning-AI/pytorch-lightning#11524.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, is there a way to confirm that this fixes the issue?
I was running it locally, but not much as it is the function that would be used for pytest skipif for testing... so loop 😕 |
What does this PR do?
Fixes #770
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃