Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check for available modules #772

Merged
merged 5 commits into from
Jan 18, 2022
Merged

fix check for available modules #772

merged 5 commits into from
Jan 18, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 17, 2022

What does this PR do?

Fixes #770

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Jan 17, 2022
@Borda Borda added this to the v0.7 milestone Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #772 (dfd6ed5) into master (9bda05a) will decrease coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff          @@
##           master   #772   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         171    171           
  Lines        6913   6926   +13     
=====================================
+ Hits         6556   6563    +7     
- Misses        357    363    +6     

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this PR fixes Lightning-AI/pytorch-lightning#11524.

@mergify mergify bot added the ready label Jan 18, 2022
@Borda Borda enabled auto-merge (squash) January 18, 2022 11:51
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is there a way to confirm that this fixes the issue?

@Borda
Copy link
Member Author

Borda commented Jan 18, 2022

Looks good, is there a way to confirm that this fixes the issue?

I was running it locally, but not much as it is the function that would be used for pytest skipif for testing... so loop 😕

@Borda Borda added the Priority Critical task/issue label Jan 18, 2022
@Borda Borda merged commit 5cb21d7 into master Jan 18, 2022
@Borda Borda deleted the fix/avail-module branch January 18, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working Priority Critical task/issue ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error importing torchmetrics
5 participants