Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilabel Ranking metrics #787

Merged
merged 46 commits into from
Mar 21, 2022
Merged

Multilabel Ranking metrics #787

merged 46 commits into from
Mar 21, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 20, 2022

What does this PR do?

Fixes #614

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added this to the v0.8 milestone Jan 20, 2022
@Borda
Copy link
Member

Borda commented Feb 5, 2022

@SkafteNicki how is it going here? 🐰

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #787 (cfd0f75) into master (1f61410) will increase coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff           @@
##           master   #787    +/-   ##
======================================
  Coverage      95%    95%            
======================================
  Files         167    169     +2     
  Lines        6947   7096   +149     
======================================
+ Hits         6603   6748   +145     
- Misses        344    348     +4     

@SkafteNicki SkafteNicki changed the title [WIP] Multilabel Ranking metrics Multilabel Ranking metrics Feb 28, 2022
@SkafteNicki SkafteNicki marked this pull request as ready for review February 28, 2022 15:31
@Borda
Copy link
Member

Borda commented Mar 18, 2022

@SkafteNicki mind checking the failers:

 TypeError: Can't instantiate abstract class LabelRankingAveragePrecision with abstract methods compute, update

@Borda Borda enabled auto-merge (squash) March 21, 2022 08:56
torchmetrics/__init__.py Outdated Show resolved Hide resolved
torchmetrics/__init__.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Mar 21, 2022
@Borda Borda merged commit 865a08f into master Mar 21, 2022
@Borda Borda deleted the ranking_metrics branch March 21, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilabel ranking metrics
3 participants