Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune deprecated: detection and pairwise #804

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

ashutoshml
Copy link
Contributor

@ashutoshml ashutoshml commented Jan 27, 2022

What does this PR do?

Fixes part of #771

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

ashutoshml and others added 3 commits January 18, 2022 23:54
* Remove deprecated functions, and warnings
* Update links for docstring
* chlog

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #804 (b472c18) into master (c6020e4) will decrease coverage by 8%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #804    +/-   ##
======================================
- Coverage      91%    83%    -8%     
======================================
  Files         171    170     -1     
  Lines        6926   6910    -16     
======================================
- Hits         6274   5720   -554     
- Misses        652   1190   +538     

@ashutoshml ashutoshml mentioned this pull request Jan 27, 2022
5 tasks
@Borda Borda added this to the v0.8 milestone Jan 27, 2022
@Borda Borda added the enhancement New feature or request label Jan 27, 2022
@mergify mergify bot added the ready label Jan 27, 2022
@Borda Borda enabled auto-merge (squash) January 27, 2022 10:55
@Borda Borda disabled auto-merge January 27, 2022 20:22
@Borda Borda merged commit 1004fc7 into Lightning-AI:master Jan 27, 2022
@ashutoshml ashutoshml deleted the prunedeprecated branch January 28, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants