Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update num_classes in jaccard score to be a required argument #853

Merged
merged 5 commits into from
Feb 22, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 21, 2022

What does this PR do?

Fixes #829

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Feb 21, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #853 (1cd919c) into master (b0bcccb) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #853   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         167    167           
  Lines        6904   6904           
=====================================
  Hits         6562   6562           
  Misses        342    342           

@Borda Borda enabled auto-merge (squash) February 22, 2022 11:22
@mergify mergify bot added the ready label Feb 22, 2022
@Borda Borda merged commit eb1c6cf into master Feb 22, 2022
@Borda Borda deleted the bugfix/jaccard_required_n_classes branch February 22, 2022 11:33
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaccard Index behaviour when num_classes is absent
3 participants