-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Perplexity metric #922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=======================================
- Coverage 94% 50% -44%
=======================================
Files 180 182 +2
Lines 8082 8141 +59
=======================================
- Hits 7596 4059 -3537
- Misses 486 4082 +3596 |
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need requires testing 🐰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryant1410 Thank you a lot for contributing! 🎉
I have one issue regarding the API of this new metric so that it will better correspond to the design of torchmetrics
.
@Borda what do you mean? To add more tests? Specifically, testing what behavior? |
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@Borda Looks like |
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃