Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RougeL/RougeLSum implementation #944

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Fix RougeL/RougeLSum implementation #944

merged 7 commits into from
Apr 11, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Apr 9, 2022

What does this PR do?

Fixes #904

This PR fixes RougeL calculation for summaries.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #944 (c174ad6) into master (717622e) will increase coverage by 24%.
The diff coverage is 98%.

@@           Coverage Diff           @@
##           master   #944     +/-   ##
=======================================
+ Coverage      71%    95%    +24%     
=======================================
  Files         173    173             
  Lines        7332   7381     +49     
=======================================
+ Hits         5181   7000   +1819     
+ Misses       2151    381   -1770     

@stancld stancld added the bug / fix Something isn't working label Apr 9, 2022
@stancld stancld added this to the v0.8 milestone Apr 9, 2022
@stancld stancld marked this pull request as ready for review April 10, 2022 09:45
@stancld stancld changed the title [WIP] Fix RougeL/RougeLSum implementation Fix RougeL/RougeLSum implementation Apr 10, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot added the ready label Apr 10, 2022
@Borda Borda enabled auto-merge (squash) April 10, 2022 23:58
@Borda Borda merged commit 0d56376 into master Apr 11, 2022
@Borda Borda deleted the bugfix/rouge-lsum branch April 11, 2022 07:54
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No difference between RougeL and RougeLsum
3 participants