Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BinnedPrecisionRecallCurve when thresholds not specified #968

Merged

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Apr 20, 2022

What does this PR do?

Fixes #969

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@DuYicong515 DuYicong515 force-pushed the fix/binned_precision_recall_default branch from 6512890 to a4ce77a Compare April 20, 2022 04:07
@DuYicong515 DuYicong515 marked this pull request as ready for review April 20, 2022 04:18
@Borda Borda added the bug / fix Something isn't working label Apr 20, 2022
@Borda Borda added this to the v0.8 milestone Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #968 (f523204) into master (10b3a85) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #968   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         177    177           
  Lines        7509   7509           
=====================================
- Hits         7137   7136    -1     
- Misses        372    373    +1     

@DuYicong515 DuYicong515 changed the title Fix BinnedPrecisionRecallCurve default Fix BinnedPrecisionRecallCurve when thresholds not specified Apr 20, 2022
@SkafteNicki SkafteNicki modified the milestones: v0.8, v0.9 Apr 20, 2022
@mergify mergify bot added the ready label Apr 20, 2022
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this :]

@Borda Borda enabled auto-merge (squash) April 20, 2022 10:10
@Borda Borda merged commit b83edf0 into Lightning-AI:master Apr 20, 2022
Borda pushed a commit that referenced this pull request Apr 26, 2022
@Borda Borda modified the milestones: v0.9, v0.8 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinnedPrecisionRecallCurve throws error when thresholds is not passed
4 participants