Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Matthews corrcoef #98

Merged
merged 15 commits into from
Mar 23, 2021
Merged

add Matthews corrcoef #98

merged 15 commits into from
Mar 23, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #59
Second metric to be requested in the issue, Matthews correlation coefficient. Again, just a port of sklearn implementation.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #98 (2fd7652) into master (84cd7ff) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   97.23%   97.27%   +0.04%     
==========================================
  Files         136       70      -66     
  Lines        4270     2167    -2103     
==========================================
- Hits         4152     2108    -2044     
+ Misses        118       59      -59     
Flag Coverage Δ
Linux 79.87% <100.00%> (+0.30%) ⬆️
Windows 79.87% <100.00%> (+0.30%) ⬆️
cpu 97.27% <100.00%> (+0.04%) ⬆️
gpu ?
macOS 97.27% <100.00%> (+0.04%) ⬆️
pytest 97.27% <100.00%> (+0.04%) ⬆️
python3.6 97.27% <100.00%> (+0.04%) ⬆️
python3.8 97.27% <100.00%> (+0.04%) ⬆️
python3.9 97.27% <100.00%> (+0.04%) ⬆️
torch1.3.1 95.69% <100.00%> (+0.06%) ⬆️
torch1.4.0 95.84% <100.00%> (+0.06%) ⬆️
torch1.8.0 97.27% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/__init__.py 100.00% <ø> (ø)
torchmetrics/classification/__init__.py 100.00% <100.00%> (ø)
torchmetrics/classification/matthews_corrcoef.py 100.00% <100.00%> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/classification/__init__.py 100.00% <100.00%> (ø)
...ics/functional/classification/matthews_corrcoef.py 100.00% <100.00%> (ø)
__w/2/s/torchmetrics/retrieval/retrieval_metric.py
.../torchmetrics/regression/mean_squared_log_error.py
__w/2/s/torchmetrics/metric.py
.../2/s/torchmetrics/regression/explained_variance.py
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84cd7ff...2fd7652. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) March 16, 2021 20:29
@Borda Borda changed the title [New metric] Matthews corrcoef add Matthews corrcoef Mar 23, 2021
@Borda Borda merged commit 536357c into master Mar 23, 2021
@Borda Borda deleted the matthews_corrcoef branch March 23, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cohen Kappa Score and Matthews Correlation Coefficient Metrics
3 participants