Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MAP metric when using custom list of thresholds #995

Merged
merged 6 commits into from
Apr 29, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 28, 2022

What does this PR do?

Fixes #994

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Apr 28, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #995 (ecb6f2e) into master (3a141ae) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #995   +/-   ##
=====================================
  Coverage      94%    95%           
=====================================
  Files         179    179           
  Lines        7640   7644    +4     
=====================================
+ Hits         7218   7242   +24     
+ Misses        422    402   -20     

@mergify mergify bot added the ready label Apr 28, 2022
@SkafteNicki SkafteNicki enabled auto-merge (squash) April 28, 2022 17:09
@SkafteNicki SkafteNicki merged commit 9011ec9 into master Apr 29, 2022
@SkafteNicki SkafteNicki deleted the bugfix/map_with_custom_threshold branch April 29, 2022 13:35
@Borda Borda added this to the v0.8 milestone May 5, 2022
Borda pushed a commit that referenced this pull request May 5, 2022
(cherry picked from commit 9011ec9)
@ekmungi
Copy link

ekmungi commented Aug 4, 2022

I have a question about this suggested fix:

I am wondering, how can I get the mAP for a custom IOU threshold = 0.25 for example? The resulting dict from mean_ap.py from the fix still gives the following format. Is the mAP calculated internally for a custom IOU (for example = 0.25)?

{'map': , 'map_50': , 'map_75': , 'map_large': , 'map_medium': , 'map_per_class': , 'map_small': , 'mar_1': , 'mar_10': , 'mar_100': , 'mar_100_per_class': , 'mar_large': , 'mar_medium': , 'mar_small': }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: 0.5/0.75 is not in list - when passing a custom set of IoU thresholds to MeanAveragePrecision
4 participants