Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] reuse metrics in a progress bar #1277

Closed
Borda opened this issue Mar 29, 2020 · 6 comments
Closed

[metrics] reuse metrics in a progress bar #1277

Borda opened this issue Mar 29, 2020 · 6 comments
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Milestone

Comments

@Borda
Copy link
Member

Borda commented Mar 29, 2020

🚀 Feature

reduce duplicated metrics in general output dict and progress bar

Motivation

it can be confusing for a user to passing the same metric multiple times in single output

Pitch

in such case just specify key/name of metric shown in progress bar... but still it would make it less flexible to show what you want
just having {'loss': None, "my-var": 123} and none mean that it takes from the general/upper-level dict?

Additional context

https://pytorch-lightning.slack.com/archives/CQXV8BRH9/p1585479078063900

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on good first issue Good for newcomers labels Mar 29, 2020
@Borda Borda added this to the 0.7.3 milestone Mar 29, 2020
@cuent
Copy link
Contributor

cuent commented Mar 29, 2020

Could you elaborate a little bit more?
The problem relies on whether a user wants to override a metric such as loss, for example, which is print by default in the progress bar. So, if the user wants to keep that parent loss, it should specify “loss”: None. I notice that the output of the progress bar is here. Where this self.add_tqdm_metrics is implemented or could you provide me an idea on where to start?

@Borda Borda modified the milestones: 0.7.4, 0.7.5 Apr 24, 2020
@Borda Borda modified the milestones: 0.7.6, 0.8.0, 0.7.7 May 12, 2020
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@Borda
Copy link
Member Author

Borda commented Jun 11, 2020

I assume this will be solved in #1989

@edenlightning edenlightning changed the title reuse metrics in a progress bar [metrics] reuse metrics in a progress bar Jun 18, 2020
@stale
Copy link

stale bot commented Aug 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 17, 2020
@edenlightning edenlightning modified the milestones: 0.9.0, 0.9.x Aug 18, 2020
@stale stale bot removed the won't fix This will not be worked on label Aug 18, 2020
@SkafteNicki
Copy link
Member

@Borda I think we can close this, since users just need to use the Result objects to remove such duplications

@Borda
Copy link
Member Author

Borda commented Sep 1, 2020

@Borda I think we can close this, since users just need to use the Result objects to remove such duplications

We need to keep dics, so any thoughts about this?
Cc: @PyTorchLightning/core-contributors

@SkafteNicki
Copy link
Member

I agree that we need to keep dictionaries for backward compatibility, I just think that if we offer a solution to users that takes care of the problem (Result objects) and it is not that hard to convert from dictionaries, then it is not really a problem :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

5 participants