-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from tqdm to fastprogress for jupyter-lab friendly progress bars #1500
Labels
Comments
Could be done as a follow up to the progress bar callback PR ❤️ |
@tcwalther sorry, we don't want to add more dependencies to lightning. |
Perhaps a fast progress callback could be a good lightning bolt (https://github.com/PyTorchLightning/lightning-bolts)??? |
so open an issue there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature
Use https://github.com/fastai/fastprogress instead of tqdm for displaying progress bars.
Motivation
tqdm doesn't work well with Jupyter Lab. This creates issues with pytorch-lightning's progress bars, where each validation bar creates a newline in the cell output: #1399. This is a well-known issue in jupyter-widgets: jupyter-widgets/ipywidgets#1845
The Fast.ai people developed fastprogress as a replacement for exactly this reason.
Pitch
Replace tqdm with fastprogress.
Alternatives
The alternative is to wait for jupyter-widgets to fix the issue on their side. Given that this issue has been around since November 2017, I'm not too hopeful that it will happen, though. It looks like this would require major design changes in ipywidgets and/or jupyter-lab.
Additional context
Motivated by #1399.
The text was updated successfully, but these errors were encountered: