-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dumping raw prof files in AdvancedProfiler
#19703
Enable dumping raw prof files in AdvancedProfiler
#19703
Conversation
For your consideration, @awaelchli |
cf1947c
to
0c21547
Compare
Are there any concerns about this change, @awaelchli? Thanks! |
Just bumping this one in case it got lost in notifications, @awaelchli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clumsy Looks great to me. Just a few minor comments
AdvancedProfiler
0c21547
to
8ae52ef
Compare
Thanks for checking, @awaelchli! I've addressed your comments. Please let me know if the are remaining concerns. |
@clumsy Are you still interested in finishing the PR? I think it's very close to land. |
ff6fe92
to
4dfc086
Compare
Sure, addressed the comments, @awaelchli |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19703 +/- ##
=========================================
- Coverage 91% 82% -9%
=========================================
Files 266 263 -3
Lines 22968 22931 -37
=========================================
- Hits 20799 18755 -2044
- Misses 2169 4176 +2007 |
Nice @clumsy thank you for addressing the remaining comments. |
What does this PR do?
Adding a new
dump_stats
flag toAdvanedProfiler
to persist.prof
files collected during profiling. These files can be visualized by SnakeViz like so:snakeviz fit-run-[Strategy]DDPStrategy.on_train_end.prof
A
.prof
file is created for each profiled action, e.g.:Fixes #19698
No breaking changes, adding a new backward-compatible flag, with the new functionality disabled by default.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19703.org.readthedocs.build/en/19703/