Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Callback on training done #20133

Open
loucaspapalazarou opened this issue Jul 28, 2024 · 6 comments · May be fixed by #20162
Open

Email Callback on training done #20133

loucaspapalazarou opened this issue Jul 28, 2024 · 6 comments · May be fixed by #20162
Labels
discussion In a discussion stage feature Is an improvement or enhancement

Comments

@loucaspapalazarou
Copy link

loucaspapalazarou commented Jul 28, 2024

Description & Motivation

A simple callback that accepts a user's email and an app account password to notify the user that their training is complete by email. Inspired by wandb

The call back will use the user's email as both sender and receiver so no need for an external SMTP.

email = johndoe@gmail.com
password = os.getenv("EMAIL_PASSWORD")
email_callback = EmailCallback(email, password)

trainer = Trainer(
        ...
        callbacks=[email_callback],
    )

Screenshot 2024-07-28 124011

Could also add details on how the training went, like test or validation measures. We could also add graphs and make it an entire report. It can get as detailed as we want. It's also possible to notify the used of any potential crashes.

Would love to work on this if approved!

Pitch

A lot of the time, training takes up a number of hours and users keep checking up on their models manually. An automatic notification on a user's phone where they can't miss it will speed up the development process.

Alternatives

Users manually create the callback.

Additional context

No response

cc @Borda

@loucaspapalazarou loucaspapalazarou added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Jul 28, 2024
@Sar2580P
Copy link

The callback for training notification would be really helpful...

I would like to make contribution for this... Please assign me the issue.
Thanks...

@Borda Borda added discussion In a discussion stage and removed needs triage Waiting to be triaged by maintainers labels Jul 30, 2024
@loucaspapalazarou
Copy link
Author

@Sar2580P I opened it because I really wanted to work on it so I would love to make the PR myself but thanks for reaching out <3

@Sar2580P
Copy link

No problem bro, go ahead with it....
Best of Luck

@loucaspapalazarou
Copy link
Author

@Sar2580P Thank you bro, I will as soon as the mods feel approve it

@loucaspapalazarou loucaspapalazarou linked a pull request Aug 4, 2024 that will close this issue
7 tasks
@awaelchli
Copy link
Contributor

Hey @loucaspapalazarou The callback looks great but could we first gather some feedback from the community to make sure enough users want/can use this so it's justified to maintain it within the package?

@loucaspapalazarou
Copy link
Author

Hey @awaelchli, yup that sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion In a discussion stage feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants