-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model checkpoint naming consistency #3125
Labels
feature
Is an improvement or enhancement
help wanted
Open to be worked on
let's do it!
approved to implement
Milestone
Comments
carmocca
added
feature
Is an improvement or enhancement
help wanted
Open to be worked on
labels
Aug 24, 2020
that sounds good to me, mind link some reference for this "standard way"? also sending a PR is very welcome 🐰 |
I couldn't find any good reference other than Python's use of underscore in variable names (see PEP8). I will make "-" (default field splitter) a modifiable variable. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
help wanted
Open to be worked on
let's do it!
approved to implement
🚀 Feature
str_ver
insideformat_checkpoin_name()
ModelCheckpoint.CHECKPOINT_NAME_LAST
contain templates.Motivation
format_checkpoint_name
's docstring example. It is standard to use-
to split metrics and_
to split metric names. This makesstr_ver
's format inconsistent by using-
.ModelCheckpoint.CHECKPOINT_NAME_LAST='last-{epoch}-{acc.3f}.ckpt'
with the same parsing behaviour as regular checkpoints.Pitch
f"_v{ver}"
forf"-v{ver}"
orf".{ver}"
ModelCheckpoint.CHECKPOINT_NAME_LAST
withformat_checkpoint_name()
The text was updated successfully, but these errors were encountered: