Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model checkpoint naming consistency #3125

Closed
carmocca opened this issue Aug 24, 2020 · 2 comments · Fixed by #3163
Closed

Model checkpoint naming consistency #3125

carmocca opened this issue Aug 24, 2020 · 2 comments · Fixed by #3163
Assignees
Labels
feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement
Milestone

Comments

@carmocca
Copy link
Contributor

🚀 Feature

  1. Modify str_ver inside format_checkpoin_name()
  2. Let ModelCheckpoint.CHECKPOINT_NAME_LAST contain templates.

Motivation

  1. Going by format_checkpoint_name's docstring example. It is standard to use - to split metrics and _ to split metric names. This makes str_ver's format inconsistent by using -.
  2. It would be helpful to be able to set ModelCheckpoint.CHECKPOINT_NAME_LAST='last-{epoch}-{acc.3f}.ckpt' with the same parsing behaviour as regular checkpoints.

Pitch

  1. Replace f"_v{ver}" for f"-v{ver}" or f".{ver}"
  2. Parse ModelCheckpoint.CHECKPOINT_NAME_LAST with format_checkpoint_name()
@carmocca carmocca added feature Is an improvement or enhancement help wanted Open to be worked on labels Aug 24, 2020
@Borda
Copy link
Member

Borda commented Aug 25, 2020

that sounds good to me, mind link some reference for this "standard way"? also sending a PR is very welcome 🐰
cc: @PyTorchLightning/core-contributors

@Borda Borda added let's do it! approved to implement v1.0 allowed labels Aug 25, 2020
@carmocca
Copy link
Contributor Author

I couldn't find any good reference other than Python's use of underscore in variable names (see PEP8). I will make "-" (default field splitter) a modifiable variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants